Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37324 )
Change subject: soc/amd/common: Access ACPIMMIO via proper symbols ......................................................................
Patch Set 13:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37324/13/src/soc/amd/common/block/i... File src/soc/amd/common/block/include/amdblocks/acpimmio_map.h:
https://review.coreboot.org/c/coreboot/+/37324/13/src/soc/amd/common/block/i... PS13, Line 117: ACPIMMIO_WDT_BANK
How about _OFFSET?
Huh? How are these not base addresses? They're not PCI bars, sure, but they are absolutely base addresses. You have a base and add an offset. These are the base addresses for the register blocks associated with them.
"In computing, a base address is an address serving as a reference point ("base") for other addresses. Related addresses can be accessed using an addressing scheme."
https://en.wikipedia.org/wiki/Base_address
I mean, I don't really care about base vs bank, but saying that they're not base addresses isn't right.