[coreboot-gerrit] Change in coreboot[master]: soc/amd: move non-CAR linker scripts to common directory

[Raul Rangel (Code Review)]

Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47828 )

Change subject: soc/amd: move non-CAR linker scripts to common directory
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/47828/2/src/soc/amd/common/block/cp... 
File src/soc/amd/common/block/cpu/noncar/memlayout_x86.ld:

https://review.coreboot.org/c/coreboot/+/47828/2/src/soc/amd/common/block/cp... 
PS2, Line 86: 	_ = ASSERT(CONFIG_BOOTBLOCK_ADDR == ((CONFIG_BOOTBLOCK_ADDR + 0xFFFF) & 0xFFFF0000), "Bootblock must be 16 bit aligned");
> Is it a flaw that .reset and the entire uncompressed bootblock appears at end of coreboot. […]

Your analysis is correct. We don't need to have bootblock at the end of coreboot.rom. I think Aaron was going to remove it, but I don't think that he did.