John Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42504 )
Change subject: mb/google/volteer: Disable D3Code along with pass through mode ......................................................................
Patch Set 2:
(5 comments)
https://review.coreboot.org/c/coreboot/+/42504/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42504/1//COMMIT_MSG@7 PS1, Line 7: Disable D3Code along with pass through mode
Please add a prefix.
Done
https://review.coreboot.org/c/coreboot/+/42504/1//COMMIT_MSG@9 PS1, Line 9: support
supported
Done
https://review.coreboot.org/c/coreboot/+/42504/1//COMMIT_MSG@9 PS1, Line 9: QS
What is QS?
We are working on pre-QS silicon. QS will be next revision. Sorry, the term "QS" is what we are supposed to use. I add further comments about this temporary patch to be reverted once the PM RTD3 is validated on QS platform.
https://review.coreboot.org/c/coreboot/+/42504/1//COMMIT_MSG@9 PS1, Line 9: pass through mode(SW CM)
Please add a space before the (.
Done
https://review.coreboot.org/c/coreboot/+/42504/1//COMMIT_MSG@10 PS1, Line 10: upstream TBT firmware
Please note the firmware versions.
The upstream TBT firmware is engineering version as named "signed_TGL_HR_4C_A0_rev6_pre4_SW_CM_PM_support_ENG_VER_perst_check_fix.bin".