John Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31917 )
Change subject: soc/intel/cnl: Generate DMAR ACPI table ......................................................................
Patch Set 14:
(2 comments)
https://review.coreboot.org/#/c/31917/14/src/soc/intel/cannonlake/acpi.c File src/soc/intel/cannonlake/acpi.c:
https://review.coreboot.org/#/c/31917/14/src/soc/intel/cannonlake/acpi.c@314 PS14, Line 314: struct device *const ipu_dev = dev_find_slot(0, SA_DEVFN_IPU); : uint64_t ipuvtbar = MCHBAR64(IPUVTBAR) & VTBAR_MASK; : bool ipuvten = MCHBAR32(IPUVTBAR) & VTBAR_ENABLED; : : if (ipu_dev && ipu_dev->enabled && ipuvtbar && ipuvten) { : unsigned long tmp = current; : : current += acpi_create_dmar_drhd(current, 0, 0, ipuvtbar); : current += acpi_create_dmar_ds_pci(current, 0, 5, 0); : : acpi_dmar_drhd_fixup(tmp, current); : }
Does this even exist for CFL or CML?
There would be no impact for CFL and CML as the readings of ipuvtbar & ipuvten are 0.
https://review.coreboot.org/#/c/31917/10/src/soc/intel/cannonlake/romstage/s... File src/soc/intel/cannonlake/romstage/systemagent.c:
https://review.coreboot.org/#/c/31917/10/src/soc/intel/cannonlake/romstage/s... PS10, Line 32: if (dev) : config = dev->chip_info; : if (config && config->VtdDisable) : return; :
VT-d is one of virtual-machine extension(VMX) […]
Wrong statement. Along with cpu/memory/graphics, VT-d is one set of virtualization features. vmx refers to processor.