Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39359 )
Change subject: soc/intel/tigerlake: Save DIMM info by available nodes ......................................................................
Patch Set 2:
Patch Set 2:
Patch Set 2:
(2 comments)
+Karthik - Most likely this is not going to work for JSL.
Is that a problem? This code change is in a "tigerlake" directory. Of course, we can talk about whether the code can or cannot be shared with other platforms in the future, but I do not take this comment as challenging whether it is OK to commit as is.
Right now, jasperlake is actually using "tigerlake" directory. So, it does impact jasperlake boards. But I think this is most likely already broken for jasperlake, so your change probably doesn't break it more. I have added Karthik as FYI here.
In Jasperlake MAX_NODE is 1 as per the FSP. So all the DIMM info would have been filled earlier.