Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38549 )
Change subject: mainboard/ocp: Add support for OCP platform TiogaPass ......................................................................
Patch Set 45:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38549/43/src/mainboard/ocp/tiogapas... File src/mainboard/ocp/tiogapass/boardid.c:
PS43:
remove this unused file
Done
https://review.coreboot.org/c/coreboot/+/38549/43/src/mainboard/ocp/tiogapas... File src/mainboard/ocp/tiogapass/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/38549/43/src/mainboard/ocp/tiogapas... PS43, Line 29: # configure device interrupt routing
missed one
Done