Andrey Petrov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40736 )
Change subject: md/cedarisland_crb: rework GPIOs configuration using macros
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40736/5/src/mainboard/intel/cedaris...
File src/mainboard/intel/cedarisland_crb/include/gpio.h:
https://review.coreboot.org/c/coreboot/+/40736/5/src/mainboard/intel/cedaris...
PS5, Line 14: _PAD_CFG_STRUCT(GPP_A0, 0x44000d02, 0x00000010),
same here, I think we can skip a0-a7
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40736
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id671a9021a8313d8c3359b89c2934b929bcab1a4
Gerrit-Change-Number: 40736
Gerrit-PatchSet: 5
Gerrit-Owner: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-CC: Lance Zhao
lance.zhao@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 29 Apr 2020 02:59:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment