Werner Zeh has posted comments on this change. ( https://review.coreboot.org/28735 )
Change subject: siemens/mc_apl1: Add new mainboard variant mc_apl2 ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/#/c/28735/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/28735/1//COMMIT_MSG@10 PS1, Line 10: concerns "contains" or "is based on"
https://review.coreboot.org/#/c/28735/1/src/mainboard/siemens/mc_apl1/varian... File src/mainboard/siemens/mc_apl1/variants/mc_apl2/Kconfig:
https://review.coreboot.org/#/c/28735/1/src/mainboard/siemens/mc_apl1/varian... PS1, Line 8: select DRIVERS_UART_8250IO We do not need the IO based UART here. Either remove it now or with one of the next commits.
https://review.coreboot.org/#/c/28735/1/src/mainboard/siemens/mc_apl1/varian... File src/mainboard/siemens/mc_apl1/variants/mc_apl2/mainboard.c:
https://review.coreboot.org/#/c/28735/1/src/mainboard/siemens/mc_apl1/varian... PS1, Line 32: /* Enable additional I/O decoding range on LPC for COM 2 */ : lpc_open_pmio_window(0x2f8, 8); This is not needed as well but we can get rid of it in one of the next commits.