Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37683 )
Change subject: arch/x86: Fix S3 resume without stage cache ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37683/2/src/arch/x86/postcar_loader... File src/arch/x86/postcar_loader.c:
https://review.coreboot.org/c/coreboot/+/37683/2/src/arch/x86/postcar_loader... PS2, Line 237: postcar_cache_invalid(); Maybe a comment here to indicate that execution falls through via this function in the event there is no stage_cache. Not that it's a bug, just a little harder to follow the scenario of !NO_STAGE_CACHE since the check was removed above.