Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40534 )
Change subject: trogdor: Update pull for Sd-card detect pin ......................................................................
Patch Set 1:
(6 comments)
https://review.coreboot.org/c/coreboot/+/40534/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40534/1//COMMIT_MSG@7 PS1, Line 7: Sd-card SD card
https://review.coreboot.org/c/coreboot/+/40534/1//COMMIT_MSG@9 PS1, Line 9: SD-card SD card
https://review.coreboot.org/c/coreboot/+/40534/1//COMMIT_MSG@9 PS1, Line 9: Configuring Configure
https://review.coreboot.org/c/coreboot/+/40534/1//COMMIT_MSG@10 PS1, Line 10: Without this SD-card detection is not working as expected 1. Add it on the line above. 2. Please add a dot/period at the end of sentences.
https://review.coreboot.org/c/coreboot/+/40534/1//COMMIT_MSG@10 PS1, Line 10: SD-card SD card
https://review.coreboot.org/c/coreboot/+/40534/1//COMMIT_MSG@11 PS1, Line 11: Is there an issue/bug report for this?
Is that according to the schematics?