Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42137 )
Change subject: mb/google/hatch: make VBOOT_LID_SWITCH depend on VBOOT
......................................................................
Patch Set 1:
Patch Set 1:
thought about dropping the selection from the baseboard completely, since selecting CHROMEOS will select VBOOT_LID_SWITCH as well, but wasn't sure which was preferred
Yeah, I think we should drop this from BOARD_GOOGLE_BASEBOARD_HATCH because as you mentioned this is already selected by CHROMEOS. I had this change in my local repo, but never got a chance to push it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42137
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I060e82185997bce451648173dd97dd6a3d5d237f
Gerrit-Change-Number: 42137
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 08 Jun 2020 21:00:00 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment