Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42131 )
Change subject: mb/asrock/b85m_pro4: Correct HWM related settings ......................................................................
Patch Set 1:
(1 comment)
This change is ready for review.
https://review.coreboot.org/c/coreboot/+/42131/1/src/mainboard/asrock/b85m_p... File src/mainboard/asrock/b85m_pro4/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/42131/1/src/mainboard/asrock/b85m_p... PS1, Line 103: irq 0x30 = 0x61 # + Fan RPM sense pins
This is wrong. […]
Pin 3: N/C Pin 4: GPO to enable CPU fan RPM reading on the 4-pin connector Pin 5: GPO to enable CPU fan RPM reading on the 3-pin connector Pin 90: CHA_FAN2 tach Pin 91: N/C (can be connected to SUSACK#) Pin 93: PWR_FAN1 tach
Original value was correct.