HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41098 )
Change subject: mb/asus/p2b: Add ACPI support for p3b-f ......................................................................
Patch Set 4:
(3 comments)
https://review.coreboot.org/c/coreboot/+/41098/4/src/mainboard/asus/p2b/susp... File src/mainboard/asus/p2b/suspend.asl:
https://review.coreboot.org/c/coreboot/+/41098/4/src/mainboard/asus/p2b/susp... PS4, Line 2: /* This file is part of the coreboot project. */ please remove
https://review.coreboot.org/c/coreboot/+/41098/4/src/mainboard/asus/p2b/vari... File src/mainboard/asus/p2b/variants/p3b-f/suspend.asl:
https://review.coreboot.org/c/coreboot/+/41098/4/src/mainboard/asus/p2b/vari... PS4, Line 2: * This file is part of the coreboot project. * please remove
https://review.coreboot.org/c/coreboot/+/41098/4/src/mainboard/asus/p2b/vari... PS4, Line 35: Store you used ASL2.0 syntax, so why do you use an old 'store'? :)