Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36450 )
Change subject: mb/intel/saddlebrook: Select coreboot MP init
......................................................................
Patch Set 1:
Can we probably fix our MP init that it works again?
It's the FSP path that seems broken. I'll propose a patch to remove it.
Actually, it's just a minor option, and also enabled for apollolake/ and
cannonlake/. Not worth the Kconfig complexity to hide it for skylake/
only. I wouldn't oppose to remove it entirely, but expect there are down-
stream requirements for CNL/CFL/CML?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36450
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2db2fe92c8ba0e649dccf95ce804a97ae4a05603
Gerrit-Change-Number: 36450
Gerrit-PatchSet: 1
Gerrit-Owner: PraveenX Hodagatta Pranesh
praveenx.hodagatta.pranesh@intel.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: PraveenX Hodagatta Pranesh
praveenx.hodagatta.pranesh@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Teo Boon Tiong
boon.tiong.teo@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Comment-Date: Thu, 31 Oct 2019 13:09:19 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment