build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39139 )
Change subject: drivers/intel/fsp2_0: Add force memory retraining ......................................................................
Patch Set 1:
(6 comments)
https://review.coreboot.org/c/coreboot/+/39139/1/src/drivers/intel/fsp2_0/me... File src/drivers/intel/fsp2_0/memory_init.c:
https://review.coreboot.org/c/coreboot/+/39139/1/src/drivers/intel/fsp2_0/me... PS1, Line 54: if (mrc_cache_stash_data(MRC_SPD_DATA, fsp_version, spd_dimm_info, spd_dimm_info_sz) < 0) { line over 96 characters
https://review.coreboot.org/c/coreboot/+/39139/1/src/drivers/intel/fsp2_0/me... PS1, Line 318: printk(BIOS_SPEW, "SPD cache found, size %zx\n", code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39139/1/src/drivers/intel/fsp2_0/me... PS1, Line 318: printk(BIOS_SPEW, "SPD cache found, size %zx\n", please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39139/1/src/drivers/intel/fsp2_0/me... PS1, Line 319: region_device_sz(&rdev)); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39139/1/src/drivers/intel/fsp2_0/me... PS1, Line 319: region_device_sz(&rdev)); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39139/1/src/drivers/intel/fsp2_0/me... PS1, Line 399: if(CONFIG(ROMSTAGE_SPD_SMBUS) && !s3wake) space required before the open parenthesis '('