Attention is currently required from: Nico Huber.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48262 )
Change subject: mb/emulation/qemu-q35: Add support for SMM_TSEG with parallel MP init
......................................................................
Patch Set 6:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/48262/comment/ece0da89_fc9cef46
PS4, Line 8:
Tested w/ / w/o KVM, MP?
I'll run more tests. This was w/o KVM and multiple CPUs
File src/mainboard/emulation/qemu-q35/cpu.c:
https://review.coreboot.org/c/coreboot/+/48262/comment/02b073cb_d9b74eeb
PS4, Line 17: // *smm_save_state_size = sizeof(amd64_smm_state_save_area_t);
: *smm_save_state_size = 0x400;
Do you want to add a comment about this? ;) […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48262
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I612cebcd2ddef809434eb9bfae9d8681cda112ef
Gerrit-Change-Number: 48262
Gerrit-PatchSet: 6
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Thu, 21 Jan 2021 09:55:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment