Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48750 )
Change subject: mb/clevo/l140cu: add panel settings to the dt and hook up GMA ACPI ......................................................................
Patch Set 34:
(2 comments)
https://review.coreboot.org/c/coreboot/+/48750/34//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48750/34//COMMIT_MSG@12 PS34, Line 12: Brightness control still requires ACPI code to link the EC events to it. : This will be done in a separate change later.
is this still true? the parent commit should be sufficient, no?
The generic code can only tell how to act on events but it can't trigger them. But... maybe reword to avoid the misunderstanding "Keyboard brightness control still requires [...]" at least that's how I read it.
https://review.coreboot.org/c/coreboot/+/48750/34/src/mainboard/clevo/cml-u/... File src/mainboard/clevo/cml-u/variants/l140cu/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/48750/34/src/mainboard/clevo/cml-u/... PS34, Line 69: GMA_STATIC_DISPLAYS Is this actually what you want? The macro was introduced to reduce the historic clutter to one line because we didn't want to risk breaking things in case it does something useful for a board.