View Change

2 comments:

• Commit Message:

  • Patch Set #34, Line 12:

    Brightness control still requires ACPI code to link the EC events to it.
    This will be done in a separate change later.
    

    is this still true? the parent commit should be sufficient, no?

    The generic code can only tell how to act on events but it can't trigger
    them. But... maybe reword to avoid the misunderstanding "Keyboard
    brightness control still requires [...]" at least that's how I read it.

• File src/mainboard/clevo/cml-u/variants/l140cu/devicetree.cb:

  • Patch Set #34, Line 69: GMA_STATIC_DISPLAYS

    Is this actually what you want? The macro was introduced to reduce the
    historic clutter to one line because we didn't want to risk breaking things
    in case it does something useful for a board.

To view, visit change 48750. To unsubscribe, or for help writing mail filters, visit settings.