Attention is currently required from: Tim Wawrzynczak, Patrick Rudolph. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52767 )
Change subject: Added LabTop series Added ITE 8987E Added LOCKDIS to mark SPI as writable in SKL Added CMOS setting to disable ME ......................................................................
Patch Set 1:
(128 comments)
File src/ec/starlabs/it8987/acpi/ac.asl:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/a95de97d_ea3f8d79 PS1, Line 53: Method(_Q0B, 0, NotSerialized) // Battery Connected trailing whitespace
File src/ec/starlabs/it8987/acpi/cmos.asl:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/94ce2139_bb224861 PS1, Line 6: NVRI, 8, trailing whitespace
File src/ec/starlabs/it8987/acpi/ec.asl:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/3e7d276a_0777206e PS1, Line 33: // Our embedded controller device. trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/18388fa4_81e48f1c PS1, Line 49: Name(PVOL, ASL_PVOL_DEFOF_NUM) trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/1058449a_ff0b954d PS1, Line 82: Name(BTEN, 0) trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/6b7c72e0_6cc58f3c PS1, Line 113: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/9a08b918_6225e0c7 PS1, Line 115: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/fd121e99_a1a6612f PS1, Line 122: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/8609716b_2a8aedcb PS1, Line 125: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/67f3156b_5768d759 PS1, Line 180: Offset(0x06), trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/d39915dd_71b0ef4b PS1, Line 187: ECHK, 8, // Hot keys flag trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/15787c9c_8ed397a1 PS1, Line 198: BTHP,8, // Health Battery Percentage trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/1edca52a_247468d9 PS1, Line 208: SFAN, 8, // Set Fan Speed. trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/5b1494b1_4694981c PS1, Line 209: BTMP, 16, // Battery Temperature. trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/77f0657d_cd510eec PS1, Line 210: BCNT, 16, // Battery Cycle Count. trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/6e4375bb_d996d195 PS1, Line 240: CPTM, 8, // CPU Temperature trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/2b587801_df7a8787 PS1, Line 242: Offset(0x72), trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/0a4c5485_0bc32cc5 PS1, Line 243: TER2, 8, // Charger Temperature, Charger thermistor support trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/dd1fc24e_2b007afd PS1, Line 249: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/a4b2b9dd_518ea486 PS1, Line 278: MGIC, 8, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/eab46b0e_aed10853 PS1, Line 322: trailing whitespace
File src/ec/starlabs/it8987/acpi/hid.asl:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/845bf25d_d7a111b3 PS1, Line 32: 0x11111111, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/04deb7dc_71699b7a PS1, Line 33: 0x22222222, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/6b8bd933_790a2f6f PS1, Line 34: 0x33333333, trailing whitespace
File src/ec/starlabs/it8987/acpi/keyboard.asl:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/3e147a70_cd56de12 PS1, Line 17: } trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/a2725be2_efc0fc34 PS1, Line 22: _SB.HIDD.HPEM(8) trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/bea3a212_3d406e08 PS1, Line 29: } trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/beed2af4_0eff1261 PS1, Line 34: } trailing whitespace
File src/mainboard/starlabs/labtop/acpi/mainboard.asl:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/146e6f0c_6d52cc2b PS1, Line 37: "PRP00001", trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/a94ad7f7_a6bf5936 PS1, Line 48: /* trailing whitespace
File src/mainboard/starlabs/labtop/variants/cml/include/variant/gpio.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/4e8064b8_c652e62b PS1, Line 18: _PAD_CFG_STRUCT(GPP_E22, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | PAD_CFG0_TX_STATE, PAD_PULL(NONE)), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/ea2364b9_56ff13b8 PS1, Line 19: _PAD_CFG_STRUCT(GPP_E23, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | PAD_CFG0_TX_STATE, PAD_PULL(NONE)), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/198193c8_eecf2ba4 PS1, Line 22: _PAD_CFG_STRUCT(GPP_H6, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE), PAD_PULL(NONE)), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/50101308_08f9c268 PS1, Line 23: _PAD_CFG_STRUCT(GPP_H7, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE), PAD_PULL(NONE)), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/1f4ccf16_00084f0e PS1, Line 35: _PAD_CFG_STRUCT(GPP_A0, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), PAD_PULL(NONE)), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/422e9f24_c6528f6f PS1, Line 36: _PAD_CFG_STRUCT(GPP_A1, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), PAD_PULL(NATIVE)), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/fdc1c863_0761640c PS1, Line 37: _PAD_CFG_STRUCT(GPP_A2, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), PAD_PULL(NATIVE)), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/bfceacbd_341ae48c PS1, Line 38: _PAD_CFG_STRUCT(GPP_A3, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), PAD_PULL(NATIVE)), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/b3b34630_616d4c5a PS1, Line 39: _PAD_CFG_STRUCT(GPP_A4, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), PAD_PULL(NATIVE)), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/20e94228_abdf8427 PS1, Line 40: _PAD_CFG_STRUCT(GPP_A5, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), PAD_PULL(NONE)), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/3598f1ff_48b1c907 PS1, Line 41: _PAD_CFG_STRUCT(GPP_A6, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), PAD_PULL(NONE)), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/ab09b221_d172fc75 PS1, Line 42: _PAD_CFG_STRUCT(GPP_A7, PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(LEVEL) | PAD_BUF(TX_DISABLE) | PAD_IRQ_ROUTE(IOAPIC), PAD_PULL(UP_20K)), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/58b0bcdc_baa7ba56 PS1, Line 43: _PAD_CFG_STRUCT(GPP_A8, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), PAD_PULL(NONE)), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/36d57523_c656ca91 PS1, Line 44: _PAD_CFG_STRUCT(GPP_A9, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), PAD_PULL(DN_20K)), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/0b000f0b_84e42db7 PS1, Line 45: _PAD_CFG_STRUCT(GPP_A10, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), PAD_PULL(DN_20K)), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/7316c221_855cbdae PS1, Line 46: _PAD_CFG_STRUCT(GPP_A13, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | PAD_CFG0_TX_STATE, PAD_PULL(NONE)), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/dec98059_476e5e50 PS1, Line 47: _PAD_CFG_STRUCT(GPP_A14, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), PAD_PULL(NONE)), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/853af8f6_7efce2c0 PS1, Line 48: _PAD_CFG_STRUCT(GPP_A15, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | PAD_CFG0_TX_STATE, PAD_PULL(NONE)), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/69f72a40_3241fd6d PS1, Line 49: _PAD_CFG_STRUCT(GPP_A16, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | PAD_CFG0_TX_STATE, PAD_PULL(UP_20K)), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/3443dafa_ebec9029 PS1, Line 50: _PAD_CFG_STRUCT(GPP_A18, PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), PAD_PULL(UP_20K)), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/5bb99bb2_db12853c PS1, Line 51: _PAD_CFG_STRUCT(GPP_A19, PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), PAD_PULL(UP_20K)), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/2b9bc500_6512be74 PS1, Line 52: _PAD_CFG_STRUCT(GPP_A20, PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), PAD_PULL(UP_20K)), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/495fe802_6d262def PS1, Line 53: _PAD_CFG_STRUCT(GPP_A21, PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), PAD_PULL(UP_20K)), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/3ae256ca_2452e50a PS1, Line 54: _PAD_CFG_STRUCT(GPP_A22, PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), PAD_PULL(UP_20K)), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/c0742b75_6289cfbc PS1, Line 55: _PAD_CFG_STRUCT(GPP_A23, PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), PAD_PULL(UP_20K)), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/dcec0e4a_37b17eec PS1, Line 58: _PAD_CFG_STRUCT(GPP_B2, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), PAD_PULL(NONE)), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/ca2d1c06_7e594ba1 PS1, Line 59: _PAD_CFG_STRUCT(GPP_B3, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_TRIG(LEVEL) | PAD_IRQ_ROUTE(IOAPIC) | PAD_BUF(TX_DISABLE), PAD_PULL(NONE)), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/66400631_7abd554e PS1, Line 60: _PAD_CFG_STRUCT(GPP_B4, PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE), PAD_PULL(NONE)), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/1ad3b89a_902befa8 PS1, Line 61: _PAD_CFG_STRUCT(GPP_B11, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | PAD_CFG0_TX_STATE, PAD_PULL(NONE)), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/e89d21b7_2455d5e4 PS1, Line 62: _PAD_CFG_STRUCT(GPP_B12, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), PAD_PULL(NONE)), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/834c4599_d5459d49 PS1, Line 63: _PAD_CFG_STRUCT(GPP_B13, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), PAD_PULL(NONE)), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/278edf06_23b265a0 PS1, Line 64: _PAD_CFG_STRUCT(GPP_B14, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | PAD_CFG0_TX_STATE, PAD_PULL(NONE)), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/4bb69de9_d8cb31ad PS1, Line 65: _PAD_CFG_STRUCT(GPP_B15, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | PAD_CFG0_TX_STATE, PAD_PULL(UP_20K)), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/c32fec79_311f745f PS1, Line 66: _PAD_CFG_STRUCT(GPP_B16, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_TRIG(LEVEL) | PAD_IRQ_ROUTE(IOAPIC) | PAD_BUF(TX_DISABLE), PAD_PULL(NONE)), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/849ba5e3_8ee7062b PS1, Line 67: _PAD_CFG_STRUCT(GPP_B17, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | PAD_CFG0_TX_STATE, PAD_PULL(NONE)), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/bda5ca67_538b9029 PS1, Line 68: _PAD_CFG_STRUCT(GPP_B23, PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | PAD_CFG0_TX_STATE, PAD_PULL(NONE)), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/e9e84651_90452c54 PS1, Line 71: _PAD_CFG_STRUCT(GPP_G5, PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), PAD_PULL(UP_20K)), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/6551bcd8_f60711d6 PS1, Line 72: _PAD_CFG_STRUCT(GPP_G7, PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), PAD_PULL(DN_20K)), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/99510de2_f426497c PS1, Line 75: _PAD_CFG_STRUCT(GPP_D9, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | PAD_CFG0_TX_STATE, PAD_PULL(NONE)), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/841f2c1e_6608c857 PS1, Line 76: _PAD_CFG_STRUCT(GPP_D10, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_TRIG(LEVEL) | PAD_IRQ_ROUTE(IOAPIC) | PAD_BUF(TX_DISABLE), PAD_PULL(NONE)), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/9c83495c_6bda4d81 PS1, Line 77: _PAD_CFG_STRUCT(GPP_D11, PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(LEVEL) | PAD_IRQ_ROUTE(SCI) | PAD_BUF(TX_DISABLE) | PAD_RX_POL(INVERT), PAD_PULL(UP_20K)), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/97550ad2_a9982767 PS1, Line 78: _PAD_CFG_STRUCT(GPP_D14, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | PAD_CFG0_TX_STATE, PAD_PULL(NONE)), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/6d1f0012_56ea170a PS1, Line 79: _PAD_CFG_STRUCT(GPP_D15, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | PAD_CFG0_TX_STATE, PAD_PULL(NONE)), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/e428e8c3_9bb990c9 PS1, Line 80: _PAD_CFG_STRUCT(GPP_D16, PAD_FUNC(GPIO) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE), PAD_PULL(NONE)), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/5c6f61ec_79748579 PS1, Line 81: _PAD_CFG_STRUCT(GPP_D17, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), PAD_PULL(NONE)), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/100618d6_4b5f22d6 PS1, Line 82: _PAD_CFG_STRUCT(GPP_D18, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), PAD_PULL(NONE)), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/e76b4fad_21da7024 PS1, Line 83: _PAD_CFG_STRUCT(GPP_D19, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), PAD_PULL(NONE)), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/1ef68a73_e6401e11 PS1, Line 84: _PAD_CFG_STRUCT(GPP_D20, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), PAD_PULL(NONE)), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/cf02272e_ef3fb9bd PS1, Line 87: _PAD_CFG_STRUCT(GPP_F0, PAD_FUNC(GPIO) | PAD_RESET(RSMRST) | PAD_TRIG(LEVEL) | PAD_BUF(TX_RX_DISABLE) | PAD_CFG0_TX_STATE, PAD_PULL(NONE)), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/89d5efe7_7deb2f73 PS1, Line 88: _PAD_CFG_STRUCT(GPP_F1, PAD_FUNC(GPIO) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE), PAD_PULL(NONE)), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/67a4eee8_4eb0f0f3 PS1, Line 89: _PAD_CFG_STRUCT(GPP_F2, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | PAD_CFG0_TX_STATE, PAD_PULL(UP_20K)), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/ba95d904_a6060b84 PS1, Line 90: _PAD_CFG_STRUCT(GPP_F3, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), PAD_PULL(UP_20K)), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/30495774_9fb517c6 PS1, Line 91: _PAD_CFG_STRUCT(GPP_F4, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), PAD_PULL(UP_20K)), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/6032ad2d_96887e7d PS1, Line 92: _PAD_CFG_STRUCT(GPP_F5, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), PAD_PULL(UP_20K)), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/175667b2_fa00c8c4 PS1, Line 93: _PAD_CFG_STRUCT(GPP_F6, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), PAD_PULL(UP_20K)), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/7d695028_8389631d PS1, Line 94: _PAD_CFG_STRUCT(GPP_F7, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), PAD_PULL(UP_20K)), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/2b7046b9_961ce3c6 PS1, Line 95: _PAD_CFG_STRUCT(GPP_F10, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE), PAD_PULL(UP_20K)), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/ba77b3a1_1460d0e6 PS1, Line 98: _PAD_CFG_STRUCT(GPP_H0, PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), PAD_PULL(UP_20K)), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/4ead67c3_e924cde0 PS1, Line 99: _PAD_CFG_STRUCT(GPP_H1, PAD_FUNC(NF3) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), PAD_PULL(UP_20K)), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/10838cd3_cea2cc67 PS1, Line 100: _PAD_CFG_STRUCT(GPP_H2, PAD_FUNC(NF3) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), PAD_PULL(UP_20K)), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/c88812e4_83d8ac17 PS1, Line 101: _PAD_CFG_STRUCT(GPP_H3, PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), PAD_PULL(UP_20K)), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/468d9091_4da03a1c PS1, Line 102: _PAD_CFG_STRUCT(GPP_H4, PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), PAD_PULL(NONE)), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/c64b5cf8_5e04e432 PS1, Line 103: _PAD_CFG_STRUCT(GPP_H5, PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), PAD_PULL(NONE)), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/ead78083_2af0246d PS1, Line 104: _PAD_CFG_STRUCT(GPP_H10, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | PAD_CFG0_TX_STATE, PAD_PULL(NONE)), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/40154bb0_4d4ac11d PS1, Line 105: _PAD_CFG_STRUCT(GPP_H11, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | PAD_CFG0_TX_STATE, PAD_PULL(NONE)), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/bcee65ee_b6f048ad PS1, Line 106: _PAD_CFG_STRUCT(GPP_H12, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | PAD_CFG0_TX_STATE, PAD_PULL(NONE)), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/bcde628f_652a403f PS1, Line 107: _PAD_CFG_STRUCT(GPP_H13, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | PAD_CFG0_TX_STATE, PAD_PULL(NONE)), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/e56f21d8_ad7183fb PS1, Line 108: _PAD_CFG_STRUCT(GPP_H14, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | PAD_CFG0_TX_STATE, PAD_PULL(NONE)), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/5249cbb6_d90335b4 PS1, Line 109: _PAD_CFG_STRUCT(GPP_H15, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | PAD_CFG0_TX_STATE, PAD_PULL(NONE)), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/847cf6e7_d89f20a0 PS1, Line 110: _PAD_CFG_STRUCT(GPP_H16, PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), PAD_PULL(NONE)), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/d9a9b875_b66b0d1a PS1, Line 111: _PAD_CFG_STRUCT(GPP_H17, PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE), PAD_PULL(NONE)), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/a31e1400_84287834 PS1, Line 112: _PAD_CFG_STRUCT(GPP_H19, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | PAD_CFG0_TX_STATE, PAD_PULL(NONE)), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/e3acfdc0_93ca9537 PS1, Line 113: _PAD_CFG_STRUCT(GPP_H20, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), PAD_PULL(NONE)), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/aa7ec7ef_47fa7824 PS1, Line 114: _PAD_CFG_STRUCT(GPP_H22, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | PAD_CFG0_TX_STATE, PAD_PULL(NONE)), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/df0a2e7c_96119ae8 PS1, Line 117: _PAD_CFG_STRUCT(GPP_C2, PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | PAD_CFG0_TX_STATE, PAD_PULL(NONE)), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/48d786d7_71b4aebc PS1, Line 118: _PAD_CFG_STRUCT(GPP_C5, PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(LEVEL) | PAD_IRQ_ROUTE(SCI) | PAD_BUF(TX_DISABLE) | PAD_RX_POL(INVERT), PAD_PULL(NONE)), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/4db2abc2_ca9d78fc PS1, Line 119: _PAD_CFG_STRUCT(GPP_C8, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_TRIG(LEVEL) | PAD_IRQ_ROUTE(IOAPIC) | PAD_BUF(TX_DISABLE), PAD_PULL(UP_20K)), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/18d00f9b_4439afad PS1, Line 120: _PAD_CFG_STRUCT(GPP_C9, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_TRIG(EDGE_SINGLE) | PAD_IRQ_ROUTE(SCI) | PAD_BUF(TX_DISABLE) | PAD_RX_POL(INVERT), PAD_PULL(UP_20K)), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/0ee48896_ef523861 PS1, Line 121: _PAD_CFG_STRUCT(GPP_C10, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE), PAD_PULL(NONE)), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/2915ce69_9ca4c22b PS1, Line 122: _PAD_CFG_STRUCT(GPP_C11, PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(LEVEL) | PAD_IRQ_ROUTE(IOAPIC) | PAD_BUF(TX_DISABLE), PAD_PULL(NONE)), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/c005063a_6a8bdf78 PS1, Line 123: _PAD_CFG_STRUCT(GPP_C12, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | PAD_CFG0_TX_STATE, PAD_PULL(NONE)), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/723a9aaa_9eb09ae8 PS1, Line 124: _PAD_CFG_STRUCT(GPP_C15, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | PAD_CFG0_TX_STATE, PAD_PULL(NONE)), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/037a798d_744522f7 PS1, Line 125: _PAD_CFG_STRUCT(GPP_C16, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), PAD_PULL(NONE)), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/65dbb28f_acd298f2 PS1, Line 126: _PAD_CFG_STRUCT(GPP_C17, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), PAD_PULL(NONE)), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/b2fd956f_8fa959a2 PS1, Line 127: _PAD_CFG_STRUCT(GPP_C18, PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), PAD_PULL(NONE)), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/ab1d082a_4f8c7926 PS1, Line 128: _PAD_CFG_STRUCT(GPP_C19, PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), PAD_PULL(NONE)), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/2e603a55_e87bacc3 PS1, Line 131: _PAD_CFG_STRUCT(GPP_E2, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE), PAD_PULL(UP_20K)), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/bed957cc_7770e6a7 PS1, Line 132: _PAD_CFG_STRUCT(GPP_E3, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_TRIG(EDGE_SINGLE) | PAD_IRQ_ROUTE(SMI) | PAD_BUF(TX_DISABLE), PAD_PULL(NONE)), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/859a73a3_d1ef6eff PS1, Line 133: _PAD_CFG_STRUCT(GPP_E4, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_TRIG(LEVEL) | PAD_IRQ_ROUTE(SCI) | PAD_BUF(TX_DISABLE) | PAD_RX_POL(INVERT), PAD_PULL(UP_20K)), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/9d2f78e2_61bb17b4 PS1, Line 134: _PAD_CFG_STRUCT(GPP_E7, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_TRIG(EDGE_SINGLE) | PAD_BUF(TX_DISABLE), PAD_PULL(NONE)), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/64135070_98de4783 PS1, Line 135: _PAD_CFG_STRUCT(GPP_E11, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), PAD_PULL(NONE)), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/3a07c4e5_990b1eb5 PS1, Line 136: _PAD_CFG_STRUCT(GPP_E12, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), PAD_PULL(NONE)), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/d5c1f943_9fe60473 PS1, Line 137: _PAD_CFG_STRUCT(GPP_E15, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | PAD_CFG0_TX_STATE, PAD_PULL(NONE)), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/4bf403b1_3fe4156c PS1, Line 138: _PAD_CFG_STRUCT(GPP_E16, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_TRIG(LEVEL) | PAD_IRQ_ROUTE(SCI) | PAD_BUF(TX_DISABLE) | PAD_RX_POL(INVERT), PAD_PULL(UP_20K)), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/4ee5b92c_577af197 PS1, Line 139: _PAD_CFG_STRUCT(GPP_E17, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), PAD_PULL(NONE)), line over 96 characters
File src/soc/intel/common/block/cse/cse.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/319e379f_e62ae4f8 PS1, Line 826: printk(BIOS_DEBUG, "HECI: Disable ME set %s!\n", status ? "success" : "failure"); line over 96 characters
File src/soc/intel/skylake/lockdown.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/545513a2_64caec9d PS1, Line 13: if (chipset_lockdown >= CHIPSET_LOCKDOWN_COREBOOT) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118066): https://review.coreboot.org/c/coreboot/+/52767/comment/44526b2f_dc2d3e3a PS1, Line 18: if (chipset_lockdown == CHIPSET_LOCKDOWN_COREBOOT) { braces {} are not necessary for single statement blocks