27 Feb
2020
27 Feb
'20
2:20 a.m.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39018 )
Change subject: ec/google/chromeec: Introduce SKU_ID helpers ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39018/4/src/ec/google/chromeec/ec_b... File src/ec/google/chromeec/ec_boardid.c:
https://review.coreboot.org/c/coreboot/+/39018/4/src/ec/google/chromeec/ec_b... PS4, Line 18: #include <console/console.h> : #include <string.h>
Are these still required?
No, I noticed after push.
However is the general concept of the patchset fine now and if so I can dot all the i's?
--
To view, visit https://review.coreboot.org/c/coreboot/+/39018
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I805b25465a3b4ee3dc0cbda5feb9e9ea2493ff9e
Gerrit-Change-Number: 39018
Gerrit-PatchSet: 5
Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org
Gerrit-Assignee: Jett Rink jettrink@google.com
Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org
Gerrit-Reviewer: Daniel Kurtz djkurtz@chromium.org
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Jett Rink jettrink@google.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Sam McNally sammc@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Jett Rink jettrink@chromium.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 27 Feb 2020 00:20:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh furquan@google.com
Gerrit-MessageType: comment