Jamie Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35040 )
Change subject: soc/intel/common/block: Provide mmc.c for setting dll registers.
......................................................................
Patch Set 14:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35040/13/src/soc/intel/common/block...
File src/soc/intel/common/block/include/intelblocks/mmc.h:
https://review.coreboot.org/c/coreboot/+/35040/13/src/soc/intel/common/block...
PS13, Line 21: /*
: * Following should be defined in soc/iomap.h
: * PRERAM_MMC_BASE_ADDRESS - Provide an address to setup emmc controller's
: PCI BAR.
: */
nit: Can you please move this under SOC_INTEL_COMMON_EARLY_MMC_WAKE (i.e. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35040
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib3c72b9851f41585ec099d8ae83a721af87ed383
Gerrit-Change-Number: 35040
Gerrit-PatchSet: 14
Gerrit-Owner: Jamie Chen
jamie.chen@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jamie Chen
jamie.chen@intel.com
Gerrit-Reviewer: Kane Chen
kane.chen@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kane Chen
kane.chen@intel.corp-partner.google.com
Gerrit-Comment-Date: Tue, 27 Aug 2019 07:09:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment