Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32381 )
Change subject: soc/intel/braswell: add default option to use public FSP ......................................................................
Patch Set 10: Code-Review+2
(3 comments)
https://review.coreboot.org/#/c/32381/6/src/drivers/intel/fsp1_1/Kconfig File src/drivers/intel/fsp1_1/Kconfig:
https://review.coreboot.org/#/c/32381/6/src/drivers/intel/fsp1_1/Kconfig@52 PS6, Line 52: depends on HAVE_FSP_BIN
How about `select` instead? Then this would be enabled by […]
Done
https://review.coreboot.org/#/c/32381/6/src/drivers/intel/fsp1_1/Kconfig@58 PS6, Line 58: string "Intel FSP binary path and filename"
IIRC, we can hide the prompt conditionally, something like […]
Done
https://review.coreboot.org/#/c/32381/10/src/drivers/intel/fsp1_1/Kconfig File src/drivers/intel/fsp1_1/Kconfig:
https://review.coreboot.org/#/c/32381/10/src/drivers/intel/fsp1_1/Kconfig@57 PS10, Line 57: This must match the : value that is set in the FSP binary The public FSP has different numbers in the integration guide. I don't have the tools to check / hardware to test. If somebody could check if this needs a different default for the public binaries, that would be nice.