HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40126 )
Change subject: src: drop 'scan_bus = NULL' and 'scan_bus = 0'
......................................................................
Patch Set 4:
Patch Set 2: Code-Review+1
Patch Set 2:
How about dropping these lines? `struct device_operations` has
21 fields, I don't see what makes `.scan_bus` so special that
it needs an explicit NULL while 15 other fields don't.
I've been replacing them with NULL on some changes, but if the structs are zero'd automatically, then it shouldn't change a thing.
Done.
Thank you
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40126
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icb9e14c58153d7c14817bcde148e86e977666e4b
Gerrit-Change-Number: 40126
Gerrit-PatchSet: 4
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 04 Apr 2020 12:12:48 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment