Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42473 )
Change subject: amd/picasso/acpi: Add power resources for I2C and UART ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42473/1/src/soc/amd/picasso/acpi/ao... File src/soc/amd/picasso/acpi/aoac.asl:
https://review.coreboot.org/c/coreboot/+/42473/1/src/soc/amd/picasso/acpi/ao... PS1, Line 126: Name (_HID, EISAID("PNP0C02")) // ID for Motherboard resources Why not just conditionally use the macro above within sb_fch.asl ?
https://review.coreboot.org/c/coreboot/+/42473/1/src/soc/amd/picasso/acpi/ao... PS1, Line 142: AOAC_DEVICE(I2C4, 9, 5) Can you please comment as to the reason for choosing different Sx states?