19 Sep
2020
19 Sep
'20
7:06 a.m.
Ryan O'Leary has posted comments on this change. ( https://review.coreboot.org/c/em100/+/45538 )
Change subject: em100: Always install signal handler ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/em100/+/45538/1/em100.c File em100.c:
https://review.coreboot.org/c/em100/+/45538/1/em100.c@948 PS1, Line 948: exit_handler It looks like the exit_handler only sets do_exit_flag=1 and that flag is only used in trace mode, making this have no effect for the second reason.
--
To view, visit https://review.coreboot.org/c/em100/+/45538
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: em100
Gerrit-Branch: master
Gerrit-Change-Id: I649dc491f68f764fdb1352599ff17b36e3d39fd8
Gerrit-Change-Number: 45538
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Reviewer: Ryan O'Leary ryanoleary@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 19 Sep 2020 04:06:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment