[coreboot-gerrit] [XL] Change in coreboot[main]: soc/mediatek/mt8196: Add eDP driver

[Jitao Shi (Code Review)]

Attention is currently required from: Bincai Liu, Hung-Te Lin, Jarried Lin, Yidi Lin.

Jitao Shi has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85949?usp=email )

Change subject: soc/mediatek/mt8196: Add eDP driver
......................................................................

Patch Set 8:

(7 comments)

File src/soc/mediatek/mt8196/dp_intf.c:

https://review.coreboot.org/c/coreboot/+/85949/comment/c3689508_745ca166?usp... :
PS7, Line 181: .regs_ck = (void *)CKSYS_GP2_BASE,
             : 	.regs_mm = (void *)MMSYS1_CONFIG_BASE,
> Remove these two unused fields from here and the header.

Done

https://review.coreboot.org/c/coreboot/+/85949/comment/d20ff022_baf7a905?usp... :
PS7, Line 191: mtk_dpintf_power_on
> Now this name becomes inconsistent with other function names in this file. […]

Done

File src/soc/mediatek/mt8196/dptx.c:

https://review.coreboot.org/c/coreboot/+/85949/comment/63f00c41_5dd6a9f4?usp... :
PS7, Line 269: linkrate = mtk_dp->train_info.linkrate;
             : 	lanecount = mtk_dp->train_info.linklane_count;
> This is wrong. By the time we reach here, `mtk_dp->train_info.*` haven't been set yet. […]

Done

https://review.coreboot.org/c/coreboot/+/85949/comment/238e18a0_3dc0eba4?usp... :
PS7, Line 370: int mtk_edp_init(struct mtk_dp *mtk_dp,struct edid *edid)
> > `space required after that ',' (ctx:VxV)` […]

Done

https://review.coreboot.org/c/coreboot/+/85949/comment/49570954_f02d54d9?usp... :
PS7, Line 374: 0xFF000000
> Please confirm if this is supposed to be 0xFF000000 or 0x80000000.

Done

https://review.coreboot.org/c/coreboot/+/85949/comment/bc00ea6c_46d1741f?usp... :
PS7, Line 376: m
> u

Done

https://review.coreboot.org/c/coreboot/+/85949/comment/708b9eb9_3d9be482?usp... :
PS7, Line 393: %s
> `%s: Failed to ... […]

Done