Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49105 )
Change subject: soc/intel/skylake: Move MAX_CPUS from mb to SoC
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/49105/2/src/mainboard/intel/kblrvp/...
File src/mainboard/intel/kblrvp/Kconfig:
https://review.coreboot.org/c/coreboot/+/49105/2/src/mainboard/intel/kblrvp/...
PS2, Line 46: MAX_CPUS
It's logical cores, and there's no problem if using a larger value.
yeah sure, it's just another confusing use of the term "CPUS" that I noticed; no blocker, no todo ;)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49105
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I825625bf842e8cd22dada9a508a7176e5cc2ea57
Gerrit-Change-Number: 49105
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 05 Jan 2021 19:14:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
felixsinger@posteo.net
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Gerrit-MessageType: comment