16 May
2019
16 May
'19
10:13 a.m.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32805 )
Change subject: sdm845: Fix broken commits ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/#/c/32805/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32805/3//COMMIT_MSG@7 PS3, Line 7: sdm845: Fix broken commits Please give this line some content. At least mention Kconfig.
https://review.coreboot.org/#/c/32805/3//COMMIT_MSG@7 PS3, Line 7: sdm845 It's probably not obvious to everyone that sdm845 is an SoC.
https://review.coreboot.org/#/c/32805/3//COMMIT_MSG@13 PS3, Line 13: I38d086c379a3c2f54d1603a2fed5b33860f7f4d7 Commit hashes preferred.
--
To view, visit https://review.coreboot.org/c/coreboot/+/32805
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0195fd186ac39dd4258fe0781dd6d3d1b1d1679f
Gerrit-Change-Number: 32805
Gerrit-PatchSet: 3
Gerrit-Owner: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney mturney@codeaurora.org
Gerrit-CC: Nico Huber nico.h@gmx.de
Gerrit-CC: Nitheesh Sekar nsekar@codeaurora.org
Gerrit-CC: Prudhvi Yarlagadda pyarlaga@qualcomm.corp-partner.google.com
Gerrit-CC: SANTHOSH JANARDHANA HASSAN sahassan@google.com
Gerrit-Comment-Date: Thu, 16 May 2019 08:13:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment