EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39352 )
Change subject: lib/spd_bin: Extend LPDDR4 SPD information ......................................................................
Patch Set 5:
(6 comments)
https://review.coreboot.org/c/coreboot/+/39352/4/src/lib/spd_bin.c File src/lib/spd_bin.c:
PS4:
Most of the attributes are extend and backward compatible. […]
Done
https://review.coreboot.org/c/coreboot/+/39352/4/src/lib/spd_bin.c@63 PS4, Line 63: SPD_DRAM_LPDDR3_JEDEC
I know this wasn't added here. […]
Done
https://review.coreboot.org/c/coreboot/+/39352/4/src/lib/spd_bin.c@67 PS4, Line 67: has
okay, thanks.
Done
https://review.coreboot.org/c/coreboot/+/39352/4/src/lib/spd_bin.c@109 PS4, Line 109: is_memory_type_ddr4(dram_type) ? DDR4_ORGANIZATION : : DDR3_ORGANIZATION;
I will add it :)
Done
https://review.coreboot.org/c/coreboot/+/39352/4/src/lib/spd_bin.c@120 PS4, Line 120: is_memory_type_ddr4(dram_type) ? DDR4_ORGANIZATION : : DDR3_ORGANIZATION;
same here
Done
https://review.coreboot.org/c/coreboot/+/39352/4/src/lib/spd_bin.c@131 PS4, Line 131: int busw_offset = is_memory_type_ddr4(dram_type) ? DDR4_BUS_DEV_WIDTH : : DDR3_BUS_DEV_WIDTH;
and here
Done