Attention is currently required from: Mathew King, Bhanu Prakash Maiya. Ivy Jian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52181 )
Change subject: mb/google/guybrush/var/guybrush: Add FPMCU configration ......................................................................
Patch Set 4:
(4 comments)
This change is ready for review.
File src/mainboard/google/guybrush/mainboard.c:
https://review.coreboot.org/c/coreboot/+/52181/comment/bf3cf21f_eebbdbba PS1, Line 121: /* Default weak implementation */
code indent should use tabs where possible
done
File src/mainboard/google/guybrush/variants/guybrush/variant.c:
https://review.coreboot.org/c/coreboot/+/52181/comment/8d36da67_d817d824 PS1, Line 14: gpio_set(GPIO_32, 1);
please, no spaces at the start of a line
done
https://review.coreboot.org/c/coreboot/+/52181/comment/ed80f9d7_1214d0f2 PS1, Line 15: mdelay(3);
please, no spaces at the start of a line
done
https://review.coreboot.org/c/coreboot/+/52181/comment/7bf2e7c8_806870e1 PS1, Line 16: gpio_set(GPIO_11, 1);
please, no spaces at the start of a line
done