Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43659 )
Change subject: vc/amd/fsp/picasso: update UPD header
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43659/2/src/vendorcode/amd/fsp/pica...
File src/vendorcode/amd/fsp/picasso/FspsUpd.h:
https://review.coreboot.org/c/coreboot/+/43659/2/src/vendorcode/amd/fsp/pica...
PS2, Line 20: /** Offset 0x00C0**/ uint32_t ddi_descriptor[FSPS_UPD_DDI_DESCRIPTOR_COUNT];
You'll need to add a Cq-Depend line on this CL's commit description. […]
added the Cq-Depend for the FSP-side patch
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43659
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1e27597e22af4df65d206a38b67c4920298b30b2
Gerrit-Change-Number: 43659
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 22 Jul 2020 18:37:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment