Wim Vervoorn has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41694 )
Change subject: mb/facebook/fbg1701: Remove C_ENV_BOOTBLOCK_SIZE ......................................................................
Patch Set 6:
Patch Set 5:
Patch Set 5:
Patch Set 5:
We need to keep C_ENV_BOOTBLOCK_SIZE around until we merge top-aligned bootblock. I can rebase this and sort out the build error.
The build error is pretty clear. It because it now used the 64K default and generates a conflict. If I remove the patch that removes the C_ENV_BOOTBLOCK_SIZE setting. The build error will be gone but it needs to be removed later. If you plan to change the code so that the boot block built will be actual size this patch can remain the same but needs to be rebased on your change. What do you prefer?
If it works for you, go ahead and remove configs/ and fbg1701/Kconfig parts from this commit. I will squash those to CB:41695 on my next update.
Done.