Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41697 )
Change subject: drivers/intel/fsp2_0/hand_off_block: Remove dead decrement
......................................................................
Patch Set 2:
I wonder if this is a bug or something that was left out in refactoring
how to check?
Now the `size` parameter is not used at all. If this is a bug depends on your
quality standards. One could use the `size` parameter to check that the given
structure is sane, i.e. really fits into a block of the given size.
So can we trust FSP to write proper HOBs? No => bug, yes => no bug.
I would prefer to remove the size parameter entirely. After all, the code is
guarded by a debug option.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41697
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If3e96ac90f06966ee408964e0748730bc237ec19
Gerrit-Change-Number: 41697
Gerrit-PatchSet: 2
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Thu, 18 Jun 2020 10:22:50 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment