1 Nov
2022
1 Nov
'22
4:50 p.m.
Attention is currently required from: Jason Nien, Isaac Lee, Jon Murphy, Martin Roth.
Amanda Hwang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69087 )
Change subject: mb/google/skyrim: Select GOOGLE_SMBIOS_MAINBOARD_VERSION ......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/69087/comment/87958bf7_ba29b6fe PS1, Line 7: mb/google/skyrim:select GOOGLE_SMBIOS_MAINBOARD_VERSION
Nit: Add a space between ':' and "select". Also update "select" to "Select" i.e. […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/69087
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I97295083dbca1c285ef7359d86abac7315c654c9
Gerrit-Change-Number: 69087
Gerrit-PatchSet: 2
Gerrit-Owner: Amanda Hwang amanda_hwang@compal.corp-partner.google.com
Gerrit-Reviewer: Frank Wu frank_wu@compal.corp-partner.google.com
Gerrit-Reviewer: Isaac Lee isaaclee@google.com
Gerrit-Reviewer: Jason Nien jason.nien@amd.corp-partner.google.com
Gerrit-Reviewer: Jon Murphy jpmurphy@google.com
Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: Martin Roth martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: EricKY Cheng ericky_cheng@compal.corp-partner.google.com
Gerrit-CC: Nelson Ye nelson_ye@compal.corp-partner.google.com
Gerrit-CC: Van Chen van_chen@compal.corp-partner.google.com
Gerrit-Attention: Jason Nien jason.nien@amd.corp-partner.google.com
Gerrit-Attention: Isaac Lee isaaclee@google.com
Gerrit-Attention: Jon Murphy jpmurphy@google.com
Gerrit-Attention: Martin Roth martin.roth@amd.corp-partner.google.com
Gerrit-Comment-Date: Tue, 01 Nov 2022 15:50:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Karthik Ramasubramanian kramasub@google.com
Gerrit-MessageType: comment