Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39236 )
Change subject: mb/google/dedede: Enable trackpad support
......................................................................
Patch Set 10: Code-Review+2
(2 comments)
https://review.coreboot.org/c/coreboot/+/39236/10//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/39236/10//COMMIT_MSG@13
PS10, Line 13: TEST:
Nit: Use the usual approach like "TEST=Verify trackpad functionality. Verify I2C SCL frequency is <= 400 KHz on trackpad operation."
https://review.coreboot.org/c/coreboot/+/39236/10//COMMIT_MSG@17
PS10, Line 17: Signed-off-by: Pandya, Varshit B varshit.b.pandya@intel.com
Nit: Move this line after Change-Id line.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39236
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I52c578aef591f5be90fb709bab4c8342ea9729e6
Gerrit-Change-Number: 39236
Gerrit-PatchSet: 10
Gerrit-Owner: Varshit B Pandya
varshit.b.pandya@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 11 Mar 2020 17:59:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment