[coreboot-gerrit] Change in coreboot[master]: sc7280: Add CPUCP firmware support

[Shelley Chen (Code Review)]

Attention is currently required from: Ravi kumar, Julius Werner.
Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49768 )

Change subject: sc7280: Add CPUCP firmware support
......................................................................

Patch Set 89:

(2 comments)

File src/soc/qualcomm/sc7280/cpucp_load_reset.c:

https://review.coreboot.org/c/coreboot/+/49768/comment/642d5327_1495dc12 
PS80, Line 19: 	write32(EPSSTOP_SECURE_ACCESS_OVERRIDE, val);
> Just use setbits32() to do this in one line.

Done

File src/soc/qualcomm/sc7280/include/soc/cpucp.h:

https://review.coreboot.org/c/coreboot/+/49768/comment/f0aa5d6a_c3e443c4 
PS86, Line 6: #define EPSSTOP_EPSS_TOP (void *)0x18598000
> These should go into <soc/addressmap.h> (and we don't usually put the (void *) cast in the macro).

Done