[coreboot-gerrit] Change in coreboot[master]: src/soc/tigerlake: Enabled D3HotEnable in fsp_params

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39368 )

Change subject: src/soc/tigerlake: Enabled D3HotEnable in fsp_params
......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/39368/2/src/soc/intel/tigerlake/fsp... 
File src/soc/intel/tigerlake/fsp_params_tgl.c:

https://review.coreboot.org/c/coreboot/+/39368/2/src/soc/intel/tigerlake/fsp... 
PS2, Line 162: params->D3HotEnable = 1;
> how about we move D3HotEnable and D3ColdEnable into the device […]

My point is why does FSP have to do this? Why can't coreboot do it?

I believe we need to see what needs to be done for TcssInit in coreboot. There might be more things that are required to initialize the controllers correctly. Has anyone looked at what BWG says about it?