Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44840 )
Change subject: mb/msi/ms7721: Use PNP_IDX_EN instead of magic number
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/44840/1/src/mainboard/msi/ms7721/bo...
File src/mainboard/msi/ms7721/bootblock.c:
https://review.coreboot.org/c/coreboot/+/44840/1/src/mainboard/msi/ms7721/bo...
PS1, Line 25: 0x61
not sue if you want to do this as a follow-up, but this can be written as PNP_IDX_IO0 + 1, since the IO base registers are 16 bit registers
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44840
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ica66ad6da61376f64f9d24de015f84d250327d66
Gerrit-Change-Number: 44840
Gerrit-PatchSet: 1
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 11 Sep 2020 22:36:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment