build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42097 )
Change subject: mb/pcengines/apu2/mptable.c: fix invalid MP table and IRQ table ......................................................................
Patch Set 5:
(16 comments)
https://review.coreboot.org/c/coreboot/+/42097/5/src/mainboard/pcengines/apu... File src/mainboard/pcengines/apu2/mainboard.c:
https://review.coreboot.org/c/coreboot/+/42097/5/src/mainboard/pcengines/apu... PS5, Line 73: [0x30] = 0x12,0x1F,0x12,0x1F,0x12,0x1F,0x1F,0x00, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/42097/5/src/mainboard/pcengines/apu... PS5, Line 73: [0x30] = 0x12,0x1F,0x12,0x1F,0x12,0x1F,0x1F,0x00, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/42097/5/src/mainboard/pcengines/apu... PS5, Line 73: [0x30] = 0x12,0x1F,0x12,0x1F,0x12,0x1F,0x1F,0x00, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/42097/5/src/mainboard/pcengines/apu... PS5, Line 73: [0x30] = 0x12,0x1F,0x12,0x1F,0x12,0x1F,0x1F,0x00, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/42097/5/src/mainboard/pcengines/apu... PS5, Line 73: [0x30] = 0x12,0x1F,0x12,0x1F,0x12,0x1F,0x1F,0x00, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/42097/5/src/mainboard/pcengines/apu... PS5, Line 73: [0x30] = 0x12,0x1F,0x12,0x1F,0x12,0x1F,0x1F,0x00, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/42097/5/src/mainboard/pcengines/apu... PS5, Line 73: [0x30] = 0x12,0x1F,0x12,0x1F,0x12,0x1F,0x1F,0x00, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/42097/5/src/mainboard/pcengines/apu... PS5, Line 95: {IOMMU_DEVFN, {PIRQ_A, PIRQ_NC, PIRQ_NC, PIRQ_NC}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/42097/5/src/mainboard/pcengines/apu... PS5, Line 96: {NB_PCIE_PORT1_DEVFN, {PIRQ_A, PIRQ_B, PIRQ_C, PIRQ_D}}, /* NIC: 02.1 */ space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/42097/5/src/mainboard/pcengines/apu... PS5, Line 97: {NB_PCIE_PORT2_DEVFN, {PIRQ_B, PIRQ_C, PIRQ_D, PIRQ_A}}, /* NIC: 02.2 */ space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/42097/5/src/mainboard/pcengines/apu... PS5, Line 99: {NB_PCIE_PORT4_DEVFN, {PIRQ_D, PIRQ_A, PIRQ_B, PIRQ_C}}, /* NIC: 02.4 */ space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/42097/5/src/mainboard/pcengines/apu... PS5, Line 100: {NB_PCIE_PORT5_DEVFN, {PIRQ_A, PIRQ_B, PIRQ_C, PIRQ_D}}, /* mPCIe slot 1: 02.5 */ space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/42097/5/src/mainboard/pcengines/apu... PS5, Line 103: {EHCI1_DEVFN, {PIRQ_EHCI1, PIRQ_NC, PIRQ_NC, PIRQ_NC}}, /* EHCI0: 12.0 */ space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/42097/5/src/mainboard/pcengines/apu... PS5, Line 104: {EHCI2_DEVFN, {PIRQ_EHCI2, PIRQ_NC, PIRQ_NC, PIRQ_NC}}, /* EHCI1: 13.0 */ space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/42097/5/src/mainboard/pcengines/apu... PS5, Line 106: {EHCI3_DEVFN, {PIRQ_EHCI3, PIRQ_NC, PIRQ_NC, PIRQ_NC}}, /* EHCI2: 16.0 (same device as xHCI 10.0) */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/42097/5/src/mainboard/pcengines/apu... PS5, Line 106: {EHCI3_DEVFN, {PIRQ_EHCI3, PIRQ_NC, PIRQ_NC, PIRQ_NC}}, /* EHCI2: 16.0 (same device as xHCI 10.0) */ space required after that close brace '}'