Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32222 )
Change subject: mb/facebook/watson: Disable turbo ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/#/c/32222/2/src/mainboard/facebook/watson/Kconfi... File src/mainboard/facebook/watson/Kconfig:
https://review.coreboot.org/#/c/32222/2/src/mainboard/facebook/watson/Kconfi... PS2, Line 45: def_bool n
The requirement for whether or not turbo is enabled in all cases is not well-defined, and >1 custome […]
Ok, maybe I should have asked "Why a Kconfig without prompt?" :) This is what was irritating me: You'd have to change the code or add some in site-local/ to toggle it.
https://review.coreboot.org/#/c/32222/2/src/mainboard/facebook/watson/mainbo... File src/mainboard/facebook/watson/mainboard.c:
https://review.coreboot.org/#/c/32222/2/src/mainboard/facebook/watson/mainbo... PS2, Line 6: -present
Thanks for bringing this up. […]
Yes, copyright extends, but not indefinitely. That's why one usually notes the year of the first publication, it's when the countdown starts.
I guess the urge to have a more generic copyright notice that doesn't have to be updated comes from the (seemingly new) practice to add/update notices for touching files (I've seen it going as far as adding a note for removing code!?! lately) no matter how little the change was. IANAL either, but it seems it only makes sense to have such copyright notices for more creative things. IMHO, if a code (addition) doesn't contain an `if` or a loop, it's not a creative work and doesn't deserve a copyright notice.