Marc Jones has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48492 )
Change subject: soc/intel/xeon_sp: Allow ACPI SMI GNVS
......................................................................
Patch Set 2: Code-Review-2
Patch Set 2: Code-Review-1
This requires properly fetching SMM save states which is not implemented correctly with smmloader v2. Then again other things in that smihandler accessing the save state are also there and are also possibly broken...
Thanks, I didn't realize that and I didn't have a test case yet. I'll abandon this.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48492
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5e0bd092ff3b76b63a4138eaf7ca7dfa57ad3e1e
Gerrit-Change-Number: 48492
Gerrit-PatchSet: 2
Gerrit-Owner: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Jay Talbott
JayTalbott@sysproconsulting.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 10 Dec 2020 17:32:00 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment