Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29662 )
Change subject: {drivers,soc/intel/braswell}: Add C_ENVIRONMENT_BOOTBLOCK support ......................................................................
Patch Set 19:
(2 comments)
https://review.coreboot.org/#/c/29662/19/src/soc/intel/braswell/Kconfig File src/soc/intel/braswell/Kconfig:
https://review.coreboot.org/#/c/29662/19/src/soc/intel/braswell/Kconfig@57 PS19, Line 57: default 0x2000 That should be 0x4000 as lzma decoder takes about 16KiB of stack to decompress the next stage. 0x2000 might be correct if POSTCAR stage is used.
https://review.coreboot.org/#/c/29662/19/src/soc/intel/braswell/Kconfig@110 PS19, Line 110: default 0x8000 if VBOOT any reason not using 0x8000 as default?