[coreboot-gerrit] Change in coreboot[master]: soc/{apl,glk}: set GPU based on CONFIG_ONBOARD_VGA_IS_PRIMARY

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39374 )

Change subject: soc/{apl,glk}: set GPU based on CONFIG_ONBOARD_VGA_IS_PRIMARY
......................................................................

Patch Set 7:

(1 comment)

https://review.coreboot.org/c/coreboot/+/39374/7/src/soc/intel/apollolake/ro... 
File src/soc/intel/apollolake/romstage.c:

https://review.coreboot.org/c/coreboot/+/39374/7/src/soc/intel/apollolake/ro... 
PS7, Line 259: PrimaryVideoAdaptor
> I suppose that it is necessary to select an active graphics device […]

I assume it configures decoding of legacy VGA cycles. And it is actually
necessary to do that early if FSP locks the GGC register. Would be good
to check if it does. Otherwise, we could ignore this option and do it
properly in coreboot.

Did somebody test what FSPs "AUTO" option does? If it prefers PCI over
IGD, I would use that here (unless it falls back to IGD if no PCI is
detected anyway).