[coreboot-gerrit] Change in coreboot[master]: soc/intel/{apl, cnl, skl}: Add sanity check of SA_PCIEX_LENGTH_MIB

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40337 )

Change subject: soc/intel/{apl, cnl, skl}: Add sanity check of SA_PCIEX_LENGTH_MIB
......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/40337/4/src/soc/intel/apollolake/sy... 
File src/soc/intel/apollolake/systemagent.c:

https://review.coreboot.org/c/coreboot/+/40337/4/src/soc/intel/apollolake/sy... 
PS4, Line 25: 
            : #if (CONFIG_SA_PCIEX_LENGTH_MIB > 0x100) /* Max length is 256MB */
            : #error "Invalid SA_PCIEX_LENGTH_MIB selection!"
            : #endif
> May be we can put this check in soc/systemagent. […]

Is there any specific different of keeping this inside .h file ?
its due to #if you are asking ?