[coreboot-gerrit] Change in ...coreboot[master]: Makefile.inc: Compile smm files based on CONFIG_SMM_INDEPENDENT_BUILD

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33115 )

Change subject: Makefile.inc: Compile smm files based on CONFIG_SMM_INDEPENDENT_BUILD
......................................................................

Patch Set 4:

(2 comments)

https://review.coreboot.org/#/c/33115/4/src/Kconfig 
File src/Kconfig:

https://review.coreboot.org/#/c/33115/4/src/Kconfig@333 
PS4, Line 333: 	default y if STAGE_RAMSTAGE || RAMPAYLOAD
> I see it now. Anyway, I'm not sure why we would have 'independent' in the name at all. […]

agree, i will make required changes

https://review.coreboot.org/#/c/33115/4/src/arch/x86/Makefile.inc 
File src/arch/x86/Makefile.inc:

https://review.coreboot.org/#/c/33115/4/src/arch/x86/Makefile.inc@403 
PS4, Line 403: ifeq ($(CONFIG_SMM_INDEPENDENT_BUILD),y)
> I see the reason now. It was in the if/endif of arch_ramstage_x86 bits.

yes, you are right