build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58896 )
Change subject: ChromeOS: Add legacy mainboard_ec_running_ro() ......................................................................
Patch Set 2:
(1 comment)
File src/vendorcode/google/chromeos/gnvs.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132181): https://review.coreboot.org/c/coreboot/+/58896/comment/1aa3d789_d6f85e77 PS2, Line 36: bool __weak mainboard_ec_running_ro() { return true; } Bad function definition - bool __weak mainboard_ec_running_ro() should probably be bool __weak mainboard_ec_running_ro(void)