Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/87161?usp=email )
Change subject: soc/intel/cmn/cpu: Refactor USE_INTEL_FSP_MP_INIT enablement logic ......................................................................
soc/intel/cmn/cpu: Refactor USE_INTEL_FSP_MP_INIT enablement logic
The Kconfig options `USE_INTEL_FSP_MP_INIT` and `USE_INTEL_FSP_TO_CALL_COREBOOT_PUBLISH_MP_PPI` are mutually exclusive ways for the FSP to handle MP initialization.
This commit updates the `default` condition for `USE_INTEL_FSP_TO_CALL_COREBOOT_PUBLISH_MP_PPI` to `y if !USE_INTEL_FSP_MP_INIT`. This ensures that if `USE_INTEL_FSP_MP_INIT` is enabled, `USE_INTEL_FSP_TO_CALL_COREBOOT_PUBLISH_MP_PPI` will default to disabled, preventing potential conflicts in MP initialization.
The explicit `depends on !USE_INTEL_FSP_TO_CALL_COREBOOT_PUBLISH_MP_PPI` on `USE_INTEL_FSP_MP_INIT` is no longer strictly necessary due to this change in the default value, but it is kept for clarity and to explicitly state the mutual exclusivity.
TEST=Able to choose USE_INTEL_FSP_MP_INIT Kconfig for google/fatcat.
Change-Id: I9ecc7b50ed6a6b13c4ccde0a49f50a40b606a848 Signed-off-by: Subrata Banik subratabanik@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/87161 Reviewed-by: Kapil Porwal kapilporwal@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Wonkyu Kim wonkyu.kim@intel.com Reviewed-by: Karthik Ramasubramanian kramasub@google.com Reviewed-by: Jérémy Compostella jeremy.compostella@intel.com --- M src/soc/intel/common/block/cpu/Kconfig 1 file changed, 1 insertion(+), 2 deletions(-)
Approvals: Wonkyu Kim: Looks good to me, but someone else must approve build bot (Jenkins): Verified Kapil Porwal: Looks good to me, approved Karthik Ramasubramanian: Looks good to me, approved Jérémy Compostella: Looks good to me, approved
diff --git a/src/soc/intel/common/block/cpu/Kconfig b/src/soc/intel/common/block/cpu/Kconfig index 0184452..e51110e 100644 --- a/src/soc/intel/common/block/cpu/Kconfig +++ b/src/soc/intel/common/block/cpu/Kconfig @@ -124,13 +124,12 @@ config USE_INTEL_FSP_MP_INIT bool "Perform MP Initialization by FSP" default n - depends on !USE_INTEL_FSP_TO_CALL_COREBOOT_PUBLISH_MP_PPI help This option allows FSP to perform multiprocessor initialization.
config USE_INTEL_FSP_TO_CALL_COREBOOT_PUBLISH_MP_PPI bool "Perform MP Initialization by FSP using coreboot MP PPI service" - default y + default y if !USE_INTEL_FSP_MP_INIT depends on MP_SERVICES_PPI help This option allows FSP to make use of MP services PPI published by