8 Apr
2020
8 Apr
'20
6:34 p.m.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40280 )
Change subject: mb/google/volteer: Configure Type C1 Aux pins ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40280/1/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/40280/1/src/mainboard/google/voltee... PS1, Line 242: Retimer FW drives this pin Can you please add some explanation to commit message why these are being configured this way?
--
To view, visit https://review.coreboot.org/c/coreboot/+/40280
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib01956b55c117a4b4a6cbdbc9e96fd4b7d6ebc8d
Gerrit-Change-Number: 40280
Gerrit-PatchSet: 1
Gerrit-Owner: Nick Vaccaro nvaccaro@google.com
Gerrit-Reviewer: Caveh Jalali caveh@chromium.org
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Jes Klinke jbk@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 09 Apr 2020 00:34:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment