13 Apr
2021
13 Apr
'21
11:50 p.m.
Attention is currently required from: Ravi kumar, Martin Roth, Paul Menzel, mturney mturney. Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51621 )
Change subject: libpayload: Support herobrine ......................................................................
Patch Set 19:
(1 comment)
File payloads/libpayload/drivers/serial/sc7280.c:
https://review.coreboot.org/c/coreboot/+/51621/comment/2dacb2a6_09097c57 PS19, Line 1: /* SPDX-License-Identifier: GPL-2.0-only */ Is there a reason that we can't use LP_QUALCOMM_QUPV3_SERIAL_CONSOLE like trogdor and need to have a separate cs7280 serial driver defined for herobrine?
--
To view, visit https://review.coreboot.org/c/coreboot/+/51621
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic28f02cdf5c0e4c2458aee0ad7c74383c88d8874
Gerrit-Change-Number: 51621
Gerrit-PatchSet: 19
Gerrit-Owner: Ravi kumar rbokka@codeaurora.org
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney mturney@codeaurora.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com
Gerrit-CC: Shelley Chen shchen@google.com
Gerrit-Attention: Ravi kumar rbokka@codeaurora.org
Gerrit-Attention: Martin Roth martinroth@google.com
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: mturney mturney mturney@codeaurora.org
Gerrit-Comment-Date: Tue, 13 Apr 2021 21:50:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment