10 Sep
2019
10 Sep
'19
9:19 a.m.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/28647 )
Change subject: selfboot: remove bounce buffers ......................................................................
Patch Set 28:
(1 comment)
https://review.coreboot.org/c/coreboot/+/28647/28/src/lib/selfboot.c File src/lib/selfboot.c:
https://review.coreboot.org/c/coreboot/+/28647/28/src/lib/selfboot.c@152 PS28, Line 152: for (first_segment = seg = cbfssegs;; ++seg) { I happened to see this CL. Do we still need this for loop after this change?
--
To view, visit https://review.coreboot.org/c/coreboot/+/28647
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I602feb32f35e8af1d0dc4ea9f25464872c9b824c
Gerrit-Change-Number: 28647
Gerrit-PatchSet: 28
Gerrit-Owner: ron minnich rminnich@gmail.com
Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: Piotr Król piotr.krol@3mdeb.com
Gerrit-Reviewer: Werner Zeh werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Reviewer: ron minnich rminnich@gmail.com
Gerrit-CC: David Hendricks david.hendricks@gmail.com
Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-CC: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-CC: Yu-Ping Wu yupingso@google.com
Gerrit-Comment-Date: Tue, 10 Sep 2019 09:19:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment